-
-
Notifications
You must be signed in to change notification settings - Fork 32
Adding proposed tag descriptions from #28 #31
Conversation
So do we not want to include the descriptions for what packages the images include? Here's what I had proposed earlier in that thread: Tag DetailsThe official IOJS docker images augment the jessie buildpacks. The following packages are including in the various tag types the official iojs docker images support:
|
Looks great 👍 Just a couple of suggestions:
|
@jlmitch5 I think listing the packages one by one is redundant and will be difficult to maintain. A broad overview of the tags is more useful. |
Completely understand where you're coming from @pesho with this being difficult to maintain. I will say that I'm not sure that the proposed file change would have answered my original question. Language like
would have had me going into the build-deps image to see what packages were actually included. If this was just me who had the issue, I wouldn't raise it, but I want to make sure that this would solve it for @davglass and @trodrigues who also indicated they had this issue, or at least others going forward. |
Actually, maybe we could link to the docker files that these are inheriting from in the sections? Image VariantsThe |
@@ -41,3 +41,19 @@ To run a single script, you can mount it in a volume under `/usr/src/app`. From | |||
``` | |||
$ docker run -v ${PWD}:/usr/src/app -w /usr/src/app -it --rm iojs iojs index.js | |||
``` | |||
|
|||
## Image Varients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Variants" (spelling)
@jlmitch5 listing the packages added by If you want to see all packages included in the image, just run the following:
Yes, this is probably a good idea. |
@jlmitch5 I totally agree that knowing which packages are installed is important (if not for security, but to quench our insatiable curiosity!). I also agree with @pesho that maintaining that list may become unmaintainable fairly quick. For the general discussion of "which should I use?" I think that the proposed wording answers that fairly well (which is, you should probably use the default tag). For those who want to know what these things are made of, perhaps stashing the output of Example output:
|
I did not even think about hierarchical packages being hidden @pesho, you're totally right! The hot linking would be really cool @wblankenship. If that's too much of a step for a simple doc change, I understand it being not included. That could probably be part of a CI flow, but that's also a little bit crazy and excessive at the same time. I still think linking back to the Docker Hub documentation for the buildpack-deps images would be cool, but I understand if it doesn't get put in. My Docker workflow might be a little weird, but I tend to use it for development, and for that, I usually Thanks for your time and patience with me, I apologize if I'm getting too deep on this. I'm somewhat of a noob when it comes to contributing to large projects, and I want to be helpful, but I also don't want to waste y'alls time :) |
|
||
`<version>-slim:` | ||
|
||
The default tag is based off of `buildpack-deps`.`buildpack-deps` is designed for the average user of docker who has many images on thier system. It, by design, has a large number of extremely common debian packages. This reduces the number of packages that images that derive from it need to install, thus reducing the total size of all of your docker images on your system. Unless you are working in an environment where *only* the iojs image will be deployed and you have space constraints, we highly recommend using the default image of this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description seems a bit too complex to explain that slim has less packages than the default tag. I would suggest adding most of it to the description of the default tag such as:
"This tag is based off of buildpack-deps
.buildpack-deps
is designed for the average user of docker who has many images on thier system. It, by design, has a large number of extremely common debian packages. This reduces the number of packages that images that derive from it need to install, thus reducing the total size of all of your docker images on your system."
and keeping the description for slim something like:
"This image does not contain the common packages contained in the default tag. If you are working in an environment where only the iojs image will be deployed and you have space constraints, you can use this image, otherwise we highly recommend using the default image of this repository."
I think having just an explanation with no list of packages would be good enough. And yeah, a link to a a link to a generated list of packages would be great, but I think a link to the buildpack-deps images would suffice. |
@jlmitch5 You aren't wasting time, in fact you are triggering a discussion that is getting documentation into the official repos 😄 This conversation was definitely needed! The use case you described (using a container as a runtime environment for development) I believe would be perfect for the base tag. Unless you are exclusively using the That being said, if you exclusively use I like the idea of listing all of the packages that are contained in the image, but perhaps it would be more efficient to simply give the above command in documentation? Something like: # Installed Packages
To view the packages installed in one of these containers, simply run:
`docker run -it iojs:[tag] dpkg --get-selections` |
oooh, that sounds fun. Here is what I have started for all the official images: docker-library/docs#172 (work in progress). |
@wblankenship sweet, glad to be a non-nuisance! Your logic explaining why standard would be a good choice for my use case made good sense. @yosifkit checked out your PR and it looks great. I think it would be pretty cool to add the |
|
||
## Image Varients | ||
|
||
The `iojs` images come in three flavors, each designed for a specific use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The iojs
Docker image comes in three flavors [...]"
A comprehensive list of all the installed packages are nice.. but maybe not super useful for most users? I would maybe argue that there should be a more Q&A style approach for more novice users as well.
|
I ❤️ the table. Is there a way we could make that work with docker-library/docs#172 |
Just a heads up: docker-library/docs#96 (comment). Probably worth poking [email protected] to express interest 👍. |
Thanks for the heads up @yosifkit! |
Landed in docker-library/docs#172 |
Would it make sense to merge in docker-library/docs#172 to this repo @wblankenship ? |
@Starefossen may not be a bad idea |
I am closing this in favour of #52. |
#28