Skip to content

Update for node 7.9.0 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Update for node 7.9.0 #377

merged 1 commit into from
Apr 12, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 12, 2017

https://nodejs.org/en/blog/release/v7.9.0/

Not sure if anything else is needed?

I tried to run update.sh (just ./update.sh 7.9.0), but that did nothing, so the changes here were done manually. Maybe a CONTRIBUTING.md should be added?

EDIT: Doing git mv 7.8 7.9; ./update.sh worked. Should the directories here be just major and not minor? Can be discussed in separate issue, I suppose. EDIT2: #322

LaurentGoderre

This comment was marked as off-topic.

@SimenB
Copy link
Member Author

SimenB commented Apr 12, 2017

@LaurentGoderre I'm not sure what you mean, the template files are all 0.0.0. As mentioned in the OP, doing git mv 7.8 7.9; ./update.sh did the whole diff. I now amended a change in generate-stackbrew-library.sh as well, missed that one

@LaurentGoderre LaurentGoderre dismissed their stale review April 12, 2017 12:34

Oh yeah, you're right, I forgot about that part. Sorry about that

LaurentGoderre

This comment was marked as off-topic.

@chorrell
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants