Skip to content

Update to node 8.1.0 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Update to node 8.1.0 #430

merged 1 commit into from
Jun 8, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jun 8, 2017

chorrell

This comment was marked as off-topic.

Starefossen

This comment was marked as off-topic.

cebor

This comment was marked as off-topic.

@SimenB
Copy link
Member Author

SimenB commented Jun 8, 2017

I don't have merge-permission here, so someone else has to merge. IDK what the policy are for number of approvals either

@LaurentGoderre LaurentGoderre merged commit c6ba81b into nodejs:master Jun 8, 2017
@cebor
Copy link

cebor commented Jun 9, 2017

When will this pushed to docker hub?

@SimenB SimenB deleted the node-8.1 branch June 9, 2017 08:35
@SimenB
Copy link
Member Author

SimenB commented Jun 9, 2017

I have never done that before. Is it just running generate-stackbrew-library.sh and PRing the result?

@pesho
Copy link
Contributor

pesho commented Jun 9, 2017

@SimenB yes. You run generate-stackbrew-library.sh on master after merging, and PR the result to https://github.com/docker-library/official-images/. Usually whoever merges the PR also does the Docker Hub submission but in this case @LaurentGoderre forgot.

@LaurentGoderre
Copy link
Member

I didn't forget....I didn't know about that part, sorry.

@hnryjms
Copy link
Contributor

hnryjms commented Jun 9, 2017

If anyone's interested, we could probably configure Travis CI to automatically deploy images and make the PR based on the master branch. I've never contributed here, but I'd take a stab at it.

@SimenB
Copy link
Member Author

SimenB commented Jun 9, 2017

The images aren't deployed from this repo. See e.g. docker-library/official-images#3039

@SimenB
Copy link
Member Author

SimenB commented Jun 9, 2017

Let's try it 🙂
docker-library/official-images#3046

@SimenB
Copy link
Member Author

SimenB commented Jun 9, 2017

This is now available on docker hub

@westy92
Copy link
Contributor

westy92 commented Jun 9, 2017

Is there any reason why these newly-pushed images aren't getting scanned for vulnerabilities like the rest?

image

@SimenB
Copy link
Member Author

SimenB commented Jun 9, 2017

Hmm, I have no idea 😕

@yosifkit
Copy link
Contributor

yosifkit commented Jun 9, 2017

The system Docker uses on the Hub can take a little while to get though the scanning.

@westy92
Copy link
Contributor

westy92 commented Jun 9, 2017

The scanning can take a while (sometime up to a few hours), but in these cases there is an indicator that it is currently being scanned. That is not the case with these.

@tianon
Copy link
Contributor

tianon commented Jun 9, 2017

cc @toli (scanning seems to be delayed or stuck on the new node:8.1 tags? normal queue behavior, or something else going on?)

nodejs-docker-bot added a commit to nodejs-docker-bot/official-images that referenced this pull request Jun 9, 2017
@westy92
Copy link
Contributor

westy92 commented Jun 9, 2017

The 6.11.0 tags are stuck as well.

8.0.0 was stuck before but I contacted Docker support and they manually kicked off those scans.

@toli
Copy link

toli commented Jun 9, 2017

This may be a bug on my end, i'm seeing the pushes come in but not forwarding on to scanning.
i've manually submitted all {{node}} tags for rescan again, will be investigating the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.