Remove Node.js 4 #710
Merged
Remove Node.js 4 #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Node.js 4 has reached its end of life. Is there anything preventing this from being merged? |
|
I'd say maybe wait until EOL is reflected here: https://github.com/nodejs/Release/blob/master/README.md |
|
We''l wait for nodejs/Release#334 before we merge this |
|
That was my PR as well. :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 4 reaches its end-of-life today.
https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742
https://github.com/nodejs/Release