jenkins: allow citgm builds to push Jenkins build updates #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes allows citgm builds to push updates like we already do for nodejs/node. That is done by making the Jenkins status update endpoints more generic, resolving the repository name from an URL parameter. In practise this means the endpoints stay the same, but configurable: - `/node/jenkins/start` - `/citgm/jenkins/start` Repository names are validated against a whitelist.
Closed
|
I'm a bit confused... Does this allow CITGM runs on a PR to be reported back to nodejs/node? Or just to nodejs/citgm? |
|
No cross communication. Nothing will change for nodejs/node, we just enable citgm builds to report back to nodejs/citgm |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Is this ready to use now? or do we need to make some changes to the citgm repo? |
|
I think it is ready to be tested. @jbergstroem has some scripts curl-ing the bot on these endpoints whenever builds starts and ends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allows citgm builds to push updates like we already do for nodejs/node. That is done by making the Jenkins status update endpoints more generic, resolving the repository name from an URL parameter.
In practise this means the endpoints stay the same, but configurable:
/node/jenkins/start/citgm/jenkins/startRepository names are validated against a whitelist.
Refs #82 (comment)
/cc @jbergstroem @gdams