Skip to content

jenkins: allow citgm builds to push Jenkins build updates #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

phillipj
Copy link
Member

@phillipj phillipj commented Feb 4, 2017

This changes allows citgm builds to push updates like we already do for nodejs/node. That is done by making the Jenkins status update endpoints more generic, resolving the repository name from an URL parameter.

In practise this means the endpoints stay the same, but configurable:

  • /node/jenkins/start
  • /citgm/jenkins/start

Repository names are validated against a whitelist.

Refs #82 (comment)

/cc @jbergstroem @gdams

This changes allows citgm builds to push updates like we already do
for nodejs/node. That is done by making the Jenkins status update
endpoints more generic, resolving the repository name from an URL
parameter.

In practise this means the endpoints stay the same, but configurable:
- `/node/jenkins/start`
- `/citgm/jenkins/start`

Repository names are validated against a whitelist.
@gdams gdams mentioned this pull request Feb 6, 2017
@Fishrock123
Copy link
Contributor

I'm a bit confused... Does this allow CITGM runs on a PR to be reported back to nodejs/node? Or just to nodejs/citgm?

@phillipj
Copy link
Member Author

phillipj commented Feb 7, 2017

No cross communication. Nothing will change for nodejs/node, we just enable citgm builds to report back to nodejs/citgm

gdams

This comment was marked as off-topic.

@phillipj phillipj merged commit 4508301 into nodejs:master Feb 10, 2017
@phillipj phillipj deleted the generalize-jenkins-status branch February 10, 2017 11:35
@gdams
Copy link
Member

gdams commented Feb 10, 2017

Is this ready to use now? or do we need to make some changes to the citgm repo?

@phillipj
Copy link
Member Author

I think it is ready to be tested. @jbergstroem has some scripts curl-ing the bot on these endpoints whenever builds starts and ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants