Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Version release #85

Closed
scunningham opened this issue Feb 9, 2012 · 13 comments
Closed

Version release #85

scunningham opened this issue Feb 9, 2012 · 13 comments

Comments

@scunningham
Copy link

A query more than an issue: When is the next planned version release? v1.0 was back on May 11, 2011, and there have been a ton of changes since then.

@bnoordhuis
Copy link
Member

I suppose I could tag it v1.1 or v2.0 but what does it mean? There's been steady on-going development. I don't know of a key commit that would warrant a version bump. It'd be somewhat arbitrary.

@scunningham
Copy link
Author

Wow, I see a lot of changes in the past 9 months:

  • Significant API changes (API CHANGE: Remove path, query, fragment CBs. )
  • New error handling facility.
  • Parser pause capability.
  • Tons of bug fixes and security improvements.

The API change alone typically warrants a new major version number.
(Well, at least according to the folks over at http://semver.org/).
But my question was more around if there was a plan to hit a certain
milestone and tag that, or just continue to do incremental dev? If
the latter, I believe there is value in tagging with a new version
number at shorter milestones. It implies that the code has stabilized
and has been vetted, and is appropriate for inclusion in another
project. As a user of a third party library, I much prefer to wait
for a stable tag to pick up the latest version rather than the tip.
One is never quite sure what state the tip of the develop tree is in
unless paying very close attention.

Thanks,
Sean

On Thu, Feb 9, 2012 at 10:31 AM, Ben Noordhuis
[email protected]
wrote:

I suppose I could tag it v1.1 or v2.0 but what does it mean? There's been steady on-going development. I don't know of a key commit that would warrant a version bump.


Reply to this email directly or view it on GitHub:
#85 (comment)

@bnoordhuis
Copy link
Member

Fair point about the API changes. I'll tag v2.0 in a week or two, remind me if I forget.

For now, use 2498961 if you want a newer-but-stable commit to work with, it's what node.js ships with.

@scunningham
Copy link
Author

Hey Ben,

Here's your reminder. Lots of activity on the project: clearing
issues out for a tag?

Thanks,
Sean

On Thu, Feb 9, 2012 at 4:57 PM, Ben Noordhuis
[email protected]
wrote:

Fair point about the API changes. I'll tag v2.0 in a week or two, remind me if I forget.

For now, use 2498961 if you want a newer-but-stable commit to work with, it's what node.js ships with.


Reply to this email directly or view it on GitHub:
#85 (comment)

@bnoordhuis
Copy link
Member

Here's your reminder. Lots of activity on the project: clearing issues out for a tag?

Yes, kind of. There are two issues I want to lick (#97 and #99, provided that last one turns out to be a real bug) and then I'll put out v2.0.

@scunningham
Copy link
Author

Hi Ben,

I see #99 cleared out, but #97 still seems to be lingering. Are you
still waiting on a bug fix for that?

Thanks,
Sean

On Thu, Mar 1, 2012 at 10:39 AM, Ben Noordhuis
[email protected]
wrote:

Here's your reminder. Lots of activity on the project: clearing issues out for a tag?

Yes, kind of. There are two issues I want to lick (#97 and #99, provided that last one turns out to be a real bug) and then I'll put out v2.0.


Reply to this email directly or view it on GitHub:
#85 (comment)

@bnoordhuis
Copy link
Member

@scunningham: Sorry for the delay. I'm going to postpone this until node v0.8 is out. Lack of time, you know how it is.

@scunningham
Copy link
Author

Understood. Thanks for keeping me abreast.

@scunningham
Copy link
Author

Ben,

Quick ping on this. node v0.8 out a while. Any chance we can get that tag?

Thanks,
Sean

@bnoordhuis
Copy link
Member

The http_parser in v0.8 is the same as in v0.6 (commit da91852), it hasn't been upgraded since v0.6.16. I can tag the current HEAD and call it a day if you want. :-)

@scunningham
Copy link
Author

I'll take it! Gives me something tangible to work against.

Surprised the parser hasn't been picked up. You guys have made a lot of
improvements.

Thanks,
Sean

On Wed, Oct 10, 2012 at 3:24 PM, Ben Noordhuis [email protected]:

The http_parser in v0.8 is the same as in v0.6 (commit da91852da91852),
it hasn't been upgraded since v0.6.16. I can tag the current HEAD and call
it a day if you want. :-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/85#issuecomment-9316039.

@bnoordhuis
Copy link
Member

Done. :-) 3fb4e06 is the commit and, unimaginatively, v2.0 is the tag.

@scunningham
Copy link
Author

Cool. Thanks!

On Wed, Oct 10, 2012 at 4:40 PM, Ben Noordhuis [email protected]:

Done. :-) 3fb4e06 3fb4e06is the commit and, unimaginatively, v2.0 is the tag.


Reply to this email directly or view it on GitHubhttps://github.com//issues/85#issuecomment-9318692.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants