Skip to content

fix: requiring JSON files #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: requiring JSON files #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fcdfd
fix: requiring JSON files
mohd-akram Feb 26, 2025
510eef5
Merge branch 'main' into fix-json
timfish Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/get-exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async function getCjsExports (url, context, parentLoad, source) {
// Resolve the re-exported module relative to the current module.
const newUrl = pathToFileURL(require.resolve(re, { paths: [dirname(fileURLToPath(url))] })).href

if (newUrl.endsWith('.node')) {
if (newUrl.endsWith('.node') || newUrl.endsWith('.json')) {
return
}

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/re-export-cjs-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require('./something.json')
9 changes: 8 additions & 1 deletion test/hook/re-export-cjs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Hook from '../../index.js'
import foo from '../fixtures/re-export-cjs-built-in.js'
import foo2 from '../fixtures/re-export-cjs.js'
import { strictEqual } from 'assert'
import foo3 from '../fixtures/re-export-cjs-json.js'
import { deepStrictEqual, strictEqual } from 'assert'

Hook((exports, name) => {
if (name.endsWith('fixtures/re-export-cjs-built-in.js')) {
Expand All @@ -13,7 +14,13 @@ Hook((exports, name) => {
strictEqual(exports.default, 'bar')
exports.default = '2'
}

if (name.endsWith('fixtures/re-export-cjs-json.js')) {
deepStrictEqual(exports.default, { data: 'dog' })
exports.default = '3'
}
})

strictEqual(foo, '1')
strictEqual(foo2, '2')
strictEqual(foo3, '3')