This repository was archived by the owner on Nov 21, 2018. It is now read-only.
build process #264 #269
Merged
build process #264 #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource/project.js` (vs json)
|
@iojs/website would like to see if we can land this before more pieces come along (simplify the other PRs) |
|
Build seemed to run ok. +1 |
|
Good timing! Thanks @therebelrobot :) I literally just commented on #264 about wanting to put up the next PR once this merged. |
|
yw :) Let me know if you need anything else reviewed today. I'll take time out for it. |
13 tasks
|
Cool. I'll see if the other proof-of-concept is close enough or not. Build wise it is looking good but the "proof" of it is sitting in an html-driven home page which is in more of a "test" state. |
|
Well, ping me on the thread or on IRC (are you in IRC?) and I'll check it out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep merge for i18n template.json, switches to
source/project.js(vs json) --- one of many things for #264Not sure how little/big to break up these PRs to, but I have other work which builds off of this which is still isn't merge-ready. This part is fairly safe as is and gives some guidance to i18n teams on some upcoming dictionary additions (although there will probably be more as
index.md->index.html)