Skip to content

Upcoming metadata changes in V8 6.7 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjihrig opened this issue Mar 27, 2018 · 2 comments
Closed

Upcoming metadata changes in V8 6.7 #180

cjihrig opened this issue Mar 27, 2018 · 2 comments

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Mar 27, 2018

The following changes are coming:

  • v8dbg_class_SharedFunctionInfo__code__Code

    • This is now combined with SharedFunctionInfo's function_data.
    • Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
    • V8 commit: v8/v8@51ded9d

  • v8dbg_class_SharedFunctionInfo__raw_name__Object and

  • v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo

    • These are now combined as name_or_scope_info.
    • Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
    • V8 commit: v8/v8@74a663b

Refs: nodejs/node-v8#47
@mmarchini
Copy link
Contributor

I plan to start working on this next week, so we'll be prepared when V8 6.7 land on v10.0.0.

I don't think v8dbg_class_SharedFunctionInfo__function_data__Object will impact llnode. I couldn't find any call to SharedFunctionInfo::GetCode... v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object will be fun though 😅

@cjihrig
Copy link
Contributor Author

cjihrig commented May 3, 2018

I don't think v8dbg_class_SharedFunctionInfo__function_data__Object will impact llnode. I couldn't find any call to SharedFunctionInfo::GetCode...

When I originally created the postmortem metadata test, I added the constants from llnode and mdb_v8, so it could be an mdb_v8 thing.

mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 18, 2018
src: fix backtrace for V8 6.7
24a8d62 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 18, 2018
src: fix backtrace for V8 6.7
dd0b22d 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 18, 2018
src: fix backtrace for V8 6.7
9dce62f 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 18, 2018
src: fix backtrace for V8 6.7
94b6534 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 18, 2018
src: fix backtrace for V8 6.7
70a2615 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
@mmarchini mmarchini mentioned this issue May 18, 2018
Merged
1 task
mmarchini pushed a commit to mmarchini/llnode that referenced this issue May 22, 2018
src: fix backtrace for V8 6.7
05c0425 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: nodejs#180
joyeecheung pushed a commit that referenced this issue May 28, 2018
@joyeecheung
src: fix backtrace for V8 6.7
546e2c7 
V8 6.7 unifies SharedFunctionInfo::name and
SharedFunctionInfo::scope_info into
SharedFunctionInfo::name_or_scope_info. Because of that, the function's
name can be inferred either from name_or_scope_info (when it's a string)
or from ScopeInfo::FunctionName (when name_or_scope_info is a
ScopeInfo).

Also, SharedFunctionInfo::GetCode was removed because it wasn't being
used anywhere.

Ref: https://chromium-review.googlesource.com/964201
Fixes: #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjihrig @mmarchini