-
Notifications
You must be signed in to change notification settings - Fork 117
Closed
Labels
enhancementThings that enhances functionality, provided by node-core-utilsThings that enhances functionality, provided by node-core-utilsfeature requestNew features for node-core-utilsNew features for node-core-utils
Description
Often when you're going through your notifications, you end up with something on the end of the pull request URL, for example:
https://github.com/nodejs/node/pull/19201#issuecomment-371266836
https://github.com/nodejs/node/pull/19201#event-1509291051
https://github.com/nodejs/node/pull/19201/files
https://github.com/nodejs/node/pull/19201#pullrequestreview-102067476
If you run git node metadata https://github.com/nodejs/node/pull/19201#issuecomment-371266836
it just shows the help text.
It should be easy to adjust the regex to handle anything of the form
https://(?:www.)github.com/(\w\+)/(\w\+)/pull/([0-9]+).*
and just capture the three things you need (in ()
).
Also https://www.github.com/nodejs/node/pull/19201
doesn't currently work.
Metadata
Metadata
Assignees
Labels
enhancementThings that enhances functionality, provided by node-core-utilsThings that enhances functionality, provided by node-core-utilsfeature requestNew features for node-core-utilsNew features for node-core-utils