Skip to content

fix(git-node): ignore all non-gha nodes when checking for GitHub CI #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix(git-node): ignore all non-gha nodes when checking for GitHub CI #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee1fdbf
fix(git-node): ignore all non-gha nodes when checking for GitHub CI
aduh95 Sep 24, 2024
67780a3
update fixtures
aduh95 Sep 24, 2024
4b4e6e3
Update lib/pr_checker.js
aduh95 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/pr_checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED'];
const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/;
const FAST_TRACK_MIN_APPROVALS = 2;
const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork';
const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov'];

// eslint-disable-next-line no-extend-native
Array.prototype.findLastIndex ??= function findLastIndex(fn) {
Expand Down Expand Up @@ -374,9 +373,10 @@ export default class PRChecker {

// GitHub new Check API
for (const { status, conclusion, app } of checkSuites.nodes) {
if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) {
// Ignore Dependabot and Codecov check suites.
// They are expected to show up sometimes and never complete.
if (app.slug !== 'github-actions') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (app.slug !== 'github-actions') {
if (app && app.slug !== 'github-actions') {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (app.slug !== 'github-actions') {
if (app?.slug !== 'github-actions') {

a suggestion upon your suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is needed.

// Ignore all non-github check suites, such as Dependabot and Codecov.
// They are expected to show up on PRs whose head branch is not on a
// fork and never complete.
continue;
}

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/both-apis-failure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "FAILURE"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/both-apis-success.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "SUCCESS"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/check-suite-failure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "FAILURE"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/check-suite-pending.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "IN_PROGRESS"
}
]
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/check-suite-skipped.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "SKIPPED"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/check-suite-success.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "SUCCESS"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/status-failure-check-suite-succeed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "SUCCESS"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/status-succeed-check-suite-failure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"checkSuites": {
"nodes": [
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "FAILURE"
}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/github-ci/success-dependabot-queued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"conclusion": null
},
{
"app": { "slug": "github-actions" },
"status": "COMPLETED",
"conclusion": "SUCCESS"
}
Expand Down
Loading