-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
node-gyp includes $nodedir/common.gypi
when creating build files for an add-on.
Per nodejs/CTC#62 (comment), that probably isn't future-proof and it's a bad idea in general: it makes add-ons pick up compiler and linker settings that aren't intended for them and may be actively harmful. People have filed bug reports about it.
Plan of action:
- Merge
common.gypi
intoaddon.gypi
. - Strip everything that isn't needed by add-ons.
- Test the bejebus out of it with citgm.
gibfahn, murgatroid99, refack, danbev, sindresorhus and 2 more
Metadata
Metadata
Assignees
Labels
No labels