Update README with another way to install on windows #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @nodejs/platform-windows could someone with a Windows box confirm that this works (and approve)? |
benjamingr
approved these changes
Feb 18, 2018
|
This works - thanks for doing this and contributing to Node.js - what will happen now is that collaborators will review this PR for 72 hours and if there are no objections it will be merged. Thanks again - and if you have any questions about this process feel free to reach out to me (my email is on the repo homepage). |
|
Oh wow, this is an older PR, didn't notice. This LGTM - someone from @nodejs/node-gyp please merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Updated the README with another way to install the C++ build tools on windows.