Skip to content

fix: Revert make-fetch-happen on v9 #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2023
Merged

fix: Revert make-fetch-happen on v9 #2917

merged 5 commits into from
Oct 27, 2023

Conversation

lukekarrys
Copy link
Member

@lukekarrys lukekarrys commented Oct 27, 2023 •
edited
Loading

This reverts commit 02480f6.

Closes #2849
Closes #2873
Closes #2848
Closes #2850

@lukekarrys lukekarrys force-pushed the lk/revert-make-fetch-happen branch 2 times, most recently from 73db964 to ff71ed8 Compare October 27, 2023 04:15
@cclauss
Copy link
Contributor

cclauss commented Oct 27, 2023 •
edited
Loading

Upgrading to make-fetch-happen v13 is not an option?

Trott and others added 2 commits October 27, 2023 07:54
@lukekarrys lukekarrys requested a review from cclauss October 27, 2023 15:02
@lukekarrys
Copy link
Member Author

@cclauss This is to create a new v9 release (v9.4.1), which will revert make-fetch-happen to version that does not have conflicting engines.

The target of this PR is release/v9 which is a new branch I created from the v9.4.0 tag. Next I will be updating make-fetch-happen in main which will be released as v10.0.0.

@lukekarrys lukekarrys changed the title fix: Revert "update make-fetch-happen to 11.0.3 (#2796)" fix: Revert make-fetch-happen on v9 Oct 27, 2023
@lukekarrys lukekarrys mentioned this pull request Oct 27, 2023
Closed
@cclauss
Copy link
Contributor

cclauss commented Oct 27, 2023 •
edited
Loading

The Python lint failure is fixed on master:

node-gyp/gyp/pylib/gyp/generator/make.py

Line 1995 in 91fd8ff

assert install_path == self.output, f"{install_path} != {self.output}"

@lukekarrys
Copy link
Member Author

Cherry picked 1bfb083 into this branch as well to fix the linting error.

@lukekarrys lukekarrys merged commit c067d2c into release/v9 Oct 27, 2023
@lukekarrys lukekarrys deleted the lk/revert-make-fetch-happen branch October 27, 2023 17:21
This was referenced Oct 27, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @cclauss @Trott