Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 17, 2024

Bumps google-github-actions/release-please-action from 2 to 4.

See:

Release notes

Sourced from google-github-actions/release-please-action's releases.

v4.0.0

4.0.0 (2023-12-01)

⚠ BREAKING CHANGES

  • remove most configuration options in favor of manifest configuration to configure the release-please-action
  • rewrite in typescript
  • remove command option in favor of setting release-type and skip-github-release/skip-github-pull-request
  • run on node20
  • deps: upgrade release-please to v16
  • v4 release

Features

  • deps: upgrade release-please to v16 (9cf05a0)
  • remove command option in favor of setting release-type and skip-github-release/skip-github-pull-request (9cf05a0)
  • remove most configuration options in favor of manifest configuration to configure the release-please-action (9cf05a0)
  • run on node20 (9cf05a0)
  • v4 release (9cf05a0)

Bug Fixes

  • bump release-please from 16.3.0 to 16.3.1 (#876) (c9291a9)
  • restore include-component-in-tag default (false) (#888) (19431a1)

Code Refactoring

v3.7.13

3.7.13 (2023-11-06)

Bug Fixes

v3.7.12

3.7.12 (2023-09-28)

Bug Fixes

  • bump release-please from 15.12.0 to 15.13.0 (#813) (01b3219)

v3.7.11

3.7.11 (2023-07-20)

... (truncated)

Changelog

Sourced from google-github-actions/release-please-action's changelog.

4.0.2 (2023-12-18)

Bug Fixes

4.0.1 (2023-12-07)

Bug Fixes

  • bump release-please from 16.3.1 to 16.4.0 (#897) (2463dad)

4.0.0 (2023-12-01)

⚠ BREAKING CHANGES

  • remove most configuration options in favor of manifest configuration to configure the release-please-action
  • rewrite in typescript
  • remove command option in favor of setting release-type and skip-github-release/skip-github-pull-request
  • run on node20
  • deps: upgrade release-please to v16
  • v4 release

Features

  • deps: upgrade release-please to v16 (9cf05a0)
  • remove command option in favor of setting release-type and skip-github-release/skip-github-pull-request (9cf05a0)
  • remove most configuration options in favor of manifest configuration to configure the release-please-action (9cf05a0)
  • run on node20 (9cf05a0)
  • v4 release (9cf05a0)

Bug Fixes

  • bump release-please from 16.3.0 to 16.3.1 (#876) (c9291a9)
  • restore include-component-in-tag default (false) (#888) (19431a1)

Code Refactoring

3.7.13 (2023-11-06)

Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@DeeDeeG

Bumps [google-github-actions/release-please-action](https://github.com/google-github-actions/release-please-action) from 2 to 4.
- [Release notes](https://github.com/google-github-actions/release-please-action/releases)
- [Changelog](https://github.com/google-github-actions/release-please-action/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/release-please-action@v2...v4)

---
updated-dependencies:
- dependency-name: google-github-actions/release-please-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 17, 2024
@cclauss cclauss merged commit b1f1808 into main Jan 20, 2024
@cclauss cclauss deleted the dependabot/github_actions/google-github-actions/release-please-action-4 branch January 20, 2024 19:11
@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jan 25, 2024

Sorry I didn't reply even though the bot tagged me in this PR...

This bump had breaking changes that would require a total re-write of the configuration files. See "BREAKING CHANGES" here: https://github.com/google-github-actions/release-please-action/releases/tag/v4.0.0

I don't think release-please-action is working in this repo anymore after the bump, see CI warnings here: https://github.com/nodejs/node-gyp/actions/runs/7596312708/job/20689880404#step:2:1

Unexpected input(s) 'package-name', 'changelog-types', valid inputs are ['token', 'release-type', 'path', 'target-branch', 'config-file', 'manifest-file', 'repo-url', 'github-api-url', 'github-graphql-url', 'fork', 'include-component-in-tag', 'proxy-server', 'skip-github-release', 'skip-github-pull-request']

I would suggest a revert until/unless anyone is willing to read up on the new "manifest-based configuration" approach, which is what newer release-please versions mandate for any sort of serious customization. I tried to look into it and it was a bit much for me to understand.

We'd need to re-write our whole congifuration for release-please to keep using the custom commit prefixes such as build: or windows:... among other customizations we have, if I recall correctly. Looks like porting the current config to the new format would involve some fairly tedious docs reading, and the docs aren't great, IMO: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md The docs say something about support for "monorepos" being an edge case justifying why release-please manifests exist, but they are now the only supported way to customize most settings? You can probably tell I'm not a fan.

Anyway, I don't have time to look into it personally. Sorry. Please consider reverting release-please-action back to 2.x, or seeing if de-bumping to 3.x will work without config file changes.

Best Regards,
- DeeDeeG

lukekarrys pushed a commit that referenced this pull request Dec 2, 2024
Bumps [google-github-actions/release-please-action](https://github.com/google-github-actions/release-please-action) from 2 to 4.
- [Release notes](https://github.com/google-github-actions/release-please-action/releases)
- [Changelog](https://github.com/google-github-actions/release-please-action/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/release-please-action@v2...v4)

---
updated-dependencies:
- dependency-name: google-github-actions/release-please-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants