Skip to content

lib: do not check nvm path if not default release #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Currently the check for nvm mirror addresses will always happen,
even if the release in question is not default and provides it's own
url for finding headers.

This extra boolean check will ensure that non default releases will
use the embedded url for headers

Currently the check for nvm mirror addresses will always happen,
even if the release in question is not default and provides it's own
url for finding headers.

This extra boolean check will ensure that non default releases will
use the embedded url for headers
@MylesBorins
Copy link
Contributor Author

it looks like there are some tests not passing here... I'm going to dig in and see what is going on tomorrow

@rvagg
Copy link
Member

rvagg commented Feb 23, 2016

If you're using NVM_* env vars then you're basically running in to #787 which we can't really solve properly until node-gyp@4 where we can remove NVM_* entirely. Their introduction here was a mistake and needs to be reverted but we can't do it immediately because they are actually used and #878 is only just being rolled out now as an alternative.

The workaround is to not use NVM_* vars, or avoid nvm entirely for non-standard releases.

@MylesBorins
Copy link
Contributor Author

updated my nvm and all is right in the world again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants