This repository was archived by the owner on Jun 18, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 45
Reported Node.js version is incorrect #29
Comments
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 24, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 24, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 25, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
Good catch! |
I wonder if reporting the version nodereport was built against, distinct from the run version, would be useful? |
Perhaps. The report doesn't actually include the version of nodereport itself, so maybe something like |
Sounds good to me. |
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 25, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 29, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Report NodeReport version and the version of Node.js it was built against. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Nov 29, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Report NodeReport version and the version of Node.js it was built against. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
richardlau
added a commit
to richardlau/nodereport
that referenced
this issue
Dec 8, 2016
Report the versions of Node.js and its components based on the runtime and not compile time constants. Report NodeReport version and the version of Node.js it was built against. Extend the tests to validate the versions reported in the report. Fixes: nodejs#29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reports currently contain in the
NodeReport
section:If I compile nodereport with one version of Node.js (e.g. v6.9.1) and then run on another version (e.g. v6.7.0) the report incorrectly reports
v6.9.1
and notv6.7.0
(note that it correctly reportsv8: 5.1.281.83
):Looks like compile time constants are being used in
src/nodereport.cc
:zlib
andares
versions are also at risk of being incorrectly reported.Pull request incoming.
The text was updated successfully, but these errors were encountered: