Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

zlib: magical async/sync depending on callback #7028

@mscdex

Description

@mscdex

9b37b83a20 adds synchronous versions of the various zlib functions. However, it's implemented such that the synchronous versions are automatically used if a callback is not supplied.

I think that the synchronous code should follow what the fs module does and 'Sync' should be appended to the names of separate functions that do the synchronous work. To me, appending 'Sync' makes it much easier to reason about code by being more explicit about the behavior of the function.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions