v0.10.33 does not build when openssl disabled

[lovebug356]

v0.10.33 does not build when openssl disabled, v0.10.32 builds fine if openssl is disabled.

In file included from ../src/node.cc:85:0:
../src/node_crypto.h:30:25: fatal error: openssl/ssl.h: No such file or directory

include <openssl/ssl.h>

[joerg-krause]

We have the same problem at Buildroot.

It is a bug in src/node.cc introduced by commit d601c76 which includes node_crypto.h twice. Once with HAVE_OPENSSL condition and once without:

#if HAVE_OPENSSL
# include "node_crypto.h"
#endif
[...]
#include "node_crypto.h"

So you're doomed to build with openssl...

[jsiei97]

This seems to be fixed on master, but a quick fix for v0.10.33 is to ifdef the SSL2_ENABLE with HAVE_OPENSSL.

in src/node.cc at line 2582

#if HAVE_OPENSSL
    } else if (strcmp(arg, "--enable-ssl2") == 0) {
      SSL2_ENABLE = true;
      argv[i] = const_cast<char*>("");
    } else if (strcmp(arg, "--enable-ssl3") == 0) {
      SSL3_ENABLE = true;
      argv[i] = const_cast<char*>("");
#endif

[jsiei97]

Cant reproduce on cfcb1de so this issue can probably be closed.

[joerg-krause]

We are using the same patch at Buidlroot: http://git.buildroot.net/buildroot/tree/package/nodejs/nodejs-0004-fix-build-error-without-OpenSSL-support.patch

It's not fixed at master since must work is done in the 0.12 branch. The commit cfcb1de is from 2 Oct.

The SSL2 and SSL3 handling are fixes done in this way only on the stable branch 0.10.xx.

[jsiei97]

Sorry, missed the different branches...

[joerg-krause]

This issue is still not fixed in v0.10.34 :-(

[tedu]

Still an error with v0.12.0. Same fix.