deps: update gen-postmortem jobs #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
It's required by an upcoming change in V8: https://chromium-review.googlesource.com/c/v8/v8/+/598666
V8 changed the typed array threshold option from a runtime flag to a compile-time option.
V8 has changed their invalid UTF-8 handling. See https://chromium-review.googlesource.com/c/v8/v8/+/671020 for more info
Closed
|
@targos is this good to upstream? Looks like the CI passed but the branch has conflicts. |
|
yes I suppose it's good |
nodejs-ci
force-pushed
the
canary
branch
6 times, most recently
from
64bfd3c to
40073e3
Compare
nodejs-ci
force-pushed
the
canary
branch
4 times, most recently
from
14c987b to
1a0afde
Compare
|
The CL was merged. This can be closed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21
@targos can you give this a shot? If it works, I'll upstream it.