Skip to content

src: update postmortem constant name #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cjihrig
Copy link

@cjihrig cjihrig commented Nov 22, 2017

Untested, but should fix #21.

This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT to V8DBG_CLASS_MAP__INSTANCE_TYPE__CHAR following the upstream change in https://chromium-review.googlesource.com/c/v8/v8/+/768414.

Refs: v8/v8@c00bb6d
Fixes: #21

Affected core subsystem(s)

src

This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT
to V8DBG_CLASS_MAP__INSTANCE_TYPE__CHAR following the upstream
change in
https://chromium-review.googlesource.com/c/v8/v8/+/768414.
@targos
Copy link
Member

targos commented Nov 22, 2017

@targos
Copy link
Member

targos commented Nov 22, 2017

CI is not green but the build was successful and sequential/test-inspector-async-stack-traces-promise-then fails on all platforms.

Landed on canary-base in nodejs/node@7e26657. Thank you!

@targos targos closed this Nov 22, 2017
@cjihrig cjihrig deleted the map-fix branch November 23, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on SmartOS
2 participants