The option --pending-deprecation should be added to NODE_OPTIONS whitelist

[tomc974]

• Version: v8.5.0
• Platform: Microsoft Windows [version 10.0.15063] (64-bit)
• Subsystem: unknown

I wanted to enable the --pending-deprecation option via the NODE_OPTIONS env variable but received the following message when I tried to run node:

--pending-deprecation is not allowed in NODE_OPTIONS

I think it's safe to allow this option to be set in NODE_OPTIONS.

[jasnell]

Would you like to try your hand at opening a PR? :-)

[tomc974]

@jasnell Well, I'm not really a C++ dev but this one should be easy enough. I'll check if I can build Node.js on my system to implement and test this awesome feature. ;-p

[benjamingr]

Passing NODE_PENDING_DEPRECATION="1" should already work (right?)

[tomc974]

@benjamingr I didn't knew about this variable since running node --help does not mention its existence.

So what do you think we should do? Reject the PR to support --pending-deprecation option via the NODE_OPTIONS and add documentation for NODE_PENDING_DEPRECATION when running node --help or support both?

[refack]

@tomc974 thanks for the report (and the PR 😉). Would you like to try and add NODE_PENDING_DEPRECATION to the help (probably above

node/src/node.cc

Lines 3868 to 3870 in 150b8f7

	" prefixed to the module search path\n"
	"NODE_REPL_HISTORY path to the persistent REPL history\n"
	" file\n"

)