-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Closed
Labels
moduleIssues and PRs related to the module subsystem.Issues and PRs related to the module subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
- Version: nodejs/node:master
- Platform: Linux 4.10.0-38-generic rename node.js -> io.js #42~16.04.1-Ubuntu SMP Tue Oct 10 16:32:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
- Subsystem: test
Hey there!
Got this error when running tests on master:
$make test-parallel
[...]
/usr/bin/python2.7 tools/test.py --mode=release parallel -J
=== release test-require-deps-deprecation ===
Path: parallel/test-require-deps-deprecation
assert.js:42
throw new errors.AssertionError({
^
AssertionError [ERR_ASSERTION]: Missing expected exception.
at innerThrows (assert.js:186:7)
at Function.throws (assert.js:205:3)
at Object.<anonymous> (/home/benjamin/Dev/javascript/NodeFoundation/node/test/parallel/test-require-deps-deprecation.js:43:10)
at Module._compile (module.js:644:30)
at Object.Module._extensions..js (module.js:655:10)
at Module.load (module.js:563:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Function.Module.runMain (module.js:685:10)
at startup (bootstrap_node.js:192:16)
Command: out/Release/node /home/benjamin/Dev/javascript/NodeFoundation/node/test/parallel/test-require-deps-deprecation.js
[00:51|% 100|+ 1719|- 1]: Done
Makefile:242 : la recette pour la cible « test-parallel » a échouée
make: *** [test-parallel] Erreur 1
If I'm corect this was added some three days ago in this commit 7ce6d23 but I have no idea why that doesn't throws, when the patch was specifically designed to make this kind of require
throw.
Is it only me?
For the record, I thought I had done some breaking changes without wanting it, so I erase my copy and re cloned it, fetched the last updates and then ran ./configure
and make
. Build is as fresh as it can get.
Metadata
Metadata
Assignees
Labels
moduleIssues and PRs related to the module subsystem.Issues and PRs related to the module subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.