macOS Installer for Node 8.9.4 LTS Garbles a Line in License Agreement

[subecho]

• Version:
  N/A but occurs with the macOS installer for the 8.9.4 LTS release
• Platform:
  uname -a
  Darwin Zeromus.local 17.3.0 Darwin Kernel Version 17.3.0: Thu Nov 9 18:09:22 PST 2017; root:xnu-4570.31.3~1/RELEASE_X86_64 x86_64
• Subsystem:
  macOS Installer

In displaying the Software License Agreement in the Node installer it looks like two lines got garbled together onto one thus obscuring both lines. This also occurs when the SLA is printed to PDF. See the attached screenshot and PDF for the garbled lines.

node_sla_page_one.pdf

[maclover7]

cc @gibfahn

[gibfahn]

Yep, can reproduce with v8.9.4 and v8.9.3:

[gibfahn]

Introduced in v8.7.0, so probably caused by eebb2d7

[gibfahn]

Easy repro:

v=8.7.0; curl -sLO https://nodejs.org/download/release/v$v/node-v$v.pkg; o node-v$v.pkg

[apapirovski]

It seems there might be an issue with pkgbuild in later macOS versions. I'm on Darwin Kernel Version 16.7.0 and have no issues.

[gibfahn]

I'm on Darwin Kernel Version 17.3.0, so that doesn't really help narrow it down.

@nodejs/platform-macos could anyone with a kernel version between 17.3 (High Sierra) and 16.7 try the installer and see if you see the same glitching?

[apapirovski]

16.7 is Sierra so there might not be anything in between.

[gibfahn]

@apapirovski when you say there's an issue with pkgbuild, do you mean there's an issue with building the pkg, or with running it? I thought pkgbuild was only used to build the pkg.

[apapirovski]

@gibfahn I just mean that there's an issue with the actual pkg generated and it's interaction with the platform running it.