-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Closed as not planned
Labels
embeddingIssues and PRs related to embedding Node.js in another project.Issues and PRs related to embedding Node.js in another project.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.
Description
Continuing from nodejs/help#1031: src/node_counters.cc
and its ilk need to have their initialization split out into a per-isolate and per-context step for embedding to work with them. Some thoughts:
-
node.js won't know if initialization already happened if the isolate is created by the embedder, unless extra bookkeeping is added. Could hang off
MultiIsolatePlatform::RegisterIsolate()
- or could it? -
the tracing code itself isn't multi-isolate ready in the slightest, it's all globals that need to move to
IsolateData
andEnvironment
-
some tracing flavors have (possibly inevitable) process-global state that should be protected by a
uv_once_t
ornode::Mutex
.
Metadata
Metadata
Assignees
Labels
embeddingIssues and PRs related to embedding Node.js in another project.Issues and PRs related to embedding Node.js in another project.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.