-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Closed
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.Issues or PRs related to the http2 subsystem.
Description
- Version: 10.8.0
- Platform: docs
- Subsystem: http2
http2: documentation for createPushResponse()
in Http2ServerResponse
should spell out what its callback returns more clearly. My interpretation was that it would return similar to ServerHttp2Stream.pushResponse()
but it does not. In specific, headers are not passed to the callback of createPushResponse()
.
node/lib/internal/http2/compat.js
Line 670 in fc84666
callback(null, new Http2ServerResponse(stream)); |
Metadata
Metadata
Assignees
Labels
docIssues and PRs related to the documentations.Issues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.Issues or PRs related to the http2 subsystem.