Possible python version bug, during build on MacOS High Sierra

[SirR4T]

• Version: v8.11.3
• Platform: Darwin hostname.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
• Subsystem: build

When running make -j8 after pulling the latest upstream master, I sometimes see this error:

  File "../third_party/inspector_protocol/CheckProtocolCompatibility.py", line 470
    print "  Public changes since %s:" % version
                                     ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("  Public changes since %s:" % version)?
make[1]: *** [/Users/saratchandra/Play/Github/nodejs/node/out/Release/obj/gen/src/js_protocol.stamp] Error 1
make[1]: *** Waiting for unfinished jobs....
Failed to parse command-line arguments: 'str' object has no attribute 'decode'

Failed to parse command-line arguments: 'str' object has no attribute 'decode'

make[1]: *** [7f4282a28ceb040a63a7982b4d396ec51b11796f.intermediate] Error 1
make[1]: *** [463be0202ecca11b345bd9ea2e1944ad6f917b33.intermediate] Error 1
rm 2be2316469838db878135dc7e59cb5f41a42f3a7.intermediate 7f4282a28ceb040a63a7982b4d396ec51b11796f.intermediate 463be0202ecca11b345bd9ea2e1944ad6f917b33.intermediate
make: *** [node] Error 2

This seems to get fixed when running ./configure and make -j8 again, though.

[richardlau]

That SyntaxError is typical of trying to run with Python 3.

[SirR4T]

ok, But i hadn't changed my python version. So the build system is able to pick up the python2 executable (I have both python versions installed, via homebrew), but it does so only after running ./configure.

Shouldn't the python executable's path be encoded somewhere, so that subsequent make -j8 runs do not attempt to use python 3 instead?

[richardlau]

The configure script was patched in #14737 to handle the situation where python is Python 3 but this doesn't apply to invocations of python in the gyp scripts, e.g.

node/deps/v8/gypfiles/inspector.gyp

Lines 53 to 56 in 82e475d

	'python',
	'<(protocol_path)/CheckProtocolCompatibility.py',
	'--stamp', '<@(_outputs)',
	'<(inspector_path)/js_protocol.json',

[Trott]

@nodejs/python @nodejs/gyp Worth fixing somehow? Or should this be closed as wont-fix?

[refack]

First it should be reported upstream at https://chromium.googlesource.com/deps/inspector_protocol.
Second this will be solved withhttps://github.com//issues/23659

I'm going to close this as wrong repo