flaky: parallel/test-async-hooks-http-parser-destroy.js

[refack]

Failed job
Worker: https://ci.nodejs.org/computer/test-requireio_mcollina-debian9-armv7l_pi2-1/
Test:

node/test/parallel/test-async-hooks-http-parser-destroy.js

Lines 42 to 43 in f2064df

	createdIds.forEach((createdAsyncId) => {
	assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0);

[Trott]

A second failure with that test on test-requireio_svincent-debian9-armv7l_pi2-3:

https://ci.nodejs.org/job/node-test-binary-arm/6797/RUN_SUBSET=1,label=pi2-docker/console

00:18:01 not ok 36 parallel/test-async-hooks-http-parser-destroy
00:18:01   ---
00:18:01   duration_ms: 10.739
00:18:01   severity: fail
00:18:01   exitcode: 1
00:18:01   stack: |-
00:18:01     assert.js:340
00:18:01         throw err;
00:18:01         ^
00:18:01     
00:18:01     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:18:01     
00:18:01       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:18:01     
00:18:01         at createdIds.forEach (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16)
00:18:01         at Array.forEach (<anonymous>)
00:18:01         at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:18:01         at listOnTimeout (timers.js:335:15)
00:18:01         at processTimers (timers.js:279:5)
00:18:01   ...

[Trott]

A third:

https://ci.nodejs.org/job/node-test-binary-arm/6792/RUN_SUBSET=1,label=pi2-docker/console

test-requireio_mcollina-debian9-armv7l_pi2-1

17:20:28 not ok 36 parallel/test-async-hooks-http-parser-destroy
17:20:28   ---
17:20:28   duration_ms: 11.536
17:20:28   severity: fail
17:20:28   exitcode: 1
17:20:28   stack: |-
17:20:28     assert.js:340
17:20:28         throw err;
17:20:28         ^
17:20:28     
17:20:28     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
17:20:28     
17:20:28       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
17:20:28     
17:20:28         at createdIds.forEach (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16)
17:20:28         at Array.forEach (<anonymous>)
17:20:28         at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
17:20:28         at listOnTimeout (timers.js:335:15)
17:20:28         at processTimers (timers.js:279:5)
17:20:28   ...

[Trott]

Fourth: https://ci.nodejs.org/job/node-test-binary-arm/6946/RUN_SUBSET=1,label=pi2-docker/console

test-requireio_mcollina-debian9-armv7l_pi2-1

00:12:34 ok 34 parallel/test-child-process-exec-stdout-stderr-data-string
00:12:34   ---
00:12:34   duration_ms: 2.536
00:12:34   ...
00:12:36 not ok 35 parallel/test-async-hooks-http-parser-destroy
00:12:36   ---
00:12:36   duration_ms: 10.285
00:12:36   severity: fail
00:12:37   exitcode: 1
00:12:37   stack: |-
00:12:37     assert.js:340
00:12:37         throw err;
00:12:37         ^
00:12:37     
00:12:37     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:12:37     
00:12:37       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:12:37     
00:12:37         at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:12:37         at Array.forEach (<anonymous>)
00:12:37         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:12:37         at listOnTimeout (timers.js:335:15)
00:12:37         at processTimers (timers.js:279:5)
00:12:37   ...

Fifth: https://ci.nodejs.org/job/node-test-binary-arm/6946/RUN_SUBSET=1,label=pi3-docker/console

test-requireio_securogroup-debian9-arm64_pi3-2

00:12:14 not ok 41 parallel/test-async-hooks-http-parser-destroy
00:12:14   ---
00:12:14   duration_ms: 8.545
00:12:14   severity: fail
00:12:14   exitcode: 1
00:12:14   stack: |-
00:12:14     assert.js:340
00:12:14         throw err;
00:12:14         ^
00:12:14     
00:12:14     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:12:14     
00:12:14       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:12:14     
00:12:14         at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:12:14         at Array.forEach (<anonymous>)
00:12:14         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:12:14         at listOnTimeout (timers.js:335:15)
00:12:14         at processTimers (timers.js:279:5)
00:12:14   ...

[joyeecheung]

Recent data points:

Reason	parallel/test-async-hooks-http-parser-destroy
Type	JS_TEST_FAILURE
Failed PR	3 (#26810, #26739, #26805)
Appeared	test-requireio_svincent-debian9-armv7l_pi2-2, test-requireio_rvagg-debian9-armv7l_pi2-1
First CI	https://ci.nodejs.org/job/node-test-pull-request/21713/
Last CI	https://ci.nodejs.org/job/node-test-pull-request/21766/

Example

not ok 34 parallel/test-async-hooks-http-parser-destroy
  ---
  duration_ms: 10.849
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:342
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
    
        at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
        at Array.forEach (<anonymous>)
        at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
        at listOnTimeout (internal/timers.js:535:17)
        at processTimers (internal/timers.js:479:7)
  ...

[joyeecheung]

Looks like this only happens on the pis

[Trott]

https://ci.nodejs.org/job/node-test-binary-arm/7110/RUN_SUBSET=3,label=pi2-docker/console

test-requireio_svincent-debian9-armv7l_pi2-2

00:15:40 not ok 35 parallel/test-async-hooks-http-parser-destroy
00:15:40   ---
00:15:40   duration_ms: 10.990
00:15:40   severity: fail
00:15:40   exitcode: 1
00:15:40   stack: |-
00:15:40     assert.js:343
00:15:40         throw err;
00:15:40         ^
00:15:40     
00:15:40     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:15:40     
00:15:40       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:15:40     
00:15:40         at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:15:40         at Array.forEach (<anonymous>)
00:15:40         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:15:40         at listOnTimeout (internal/timers.js:535:17)
00:15:40         at processTimers (internal/timers.js:479:7)
00:15:40   ...

[Trott]

https://ci.nodejs.org/job/node-test-binary-arm/7250/RUN_SUBSET=3,label=pi1-docker/console

test-requireio_bengl-debian9-armv6l_pi1p-2

00:19:48 not ok 24 parallel/test-async-hooks-http-parser-destroy
00:19:48   ---
00:19:48   duration_ms: 14.124
00:19:48   severity: fail
00:19:48   exitcode: 1
00:19:48   stack: |-
00:19:48     assert.js:343
00:19:48         throw err;
00:19:48         ^
00:19:48     
00:19:48     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:19:48     
00:19:48       assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:19:48     
00:19:48         at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:19:48         at Array.forEach (<anonymous>)
00:19:48         at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:19:48         at listOnTimeout (internal/timers.js:535:17)
00:19:48         at processTimers (internal/timers.js:479:7)
00:19:48   ...

[Trott]

The test takes a bit longer to run than most other tests in parallel. I wonder if it can be dialed back a bit.

[Trott]

Yes, definitely room to dial it down a lot and still have it fail on the regression it is meant to test for. Experimenting a bit and will open a PR soon....

[Trott]

(Although I guess maybe not since that probably doesn't explain why this is failing on the Pi's? Maybe it will become obvious while refactoring...)