Intermittent timeouts in test-tls-min-max-version.js

[kball]

• Version: v13.0.0-pre (built from src at commit e6edd66)
• Platform: Darwin Kernel Version 17.7.0: Wed Apr 24 21:17:24 PDT 2019; root:xnu-4570.71.45~1/RELEASE_X86_64 x86_64
• Subsystem: openssl/tls

Attempting to run make test, or running test/parallel/test-tls-min-max-version.js in isolation I get intermittent timeouts.

[sam-github]

Can you post the output? Also, just to confirm, what were your configure options?

[kball]

I ran ./configure with no options; where should I look to find any info on what it determined that will be helpful?

I unfortunately did not save the output and am not currently able to reproduce. :( I'll keep trying and post it if I repro it again. Sorry for not thinking of that.

[sam-github]

Knowing that there were no options is enough.

Without some output, its hard to guess, much less repro. This runs regularly in CI on macos, and many (most?) devs are using macos, so its surprising. It also is a pretty simple test with no subtle timing races or ordering dependencies. Which doesn't mean it doesn't have a bug, but does mean that some clues are needed.

I don't even know what timeout you hit, if you run it standalone, I didn't think there were any timeouts.

[lpinca]

I can reproduce with

./tools/test.py -J --repeat=1000 test/parallel/test-tls-min-max-version.js

on master. macOS 10.14.5

[lpinca]

I dug a little and noticed a bunch of EADDRNOTAVAIL errors. When this happens

node/test/fixtures/tls-connect.js

Line 70 in 35cb955

.on('error', function(err) {

is emitted but

node/test/fixtures/tls-connect.js

Line 81 in 35cb955

}).on('tlsClientError', function(err, sock) {

is not. As a result the callback is not called and test times out. I've increased the ephemeral port range

$ sudo sysctl -w net.inet.ip.portrange.first=32768
net.inet.ip.portrange.first: 49152 -> 32768

and reduced the duration of the TIME_WAIT state

$ sudo sysctl net.inet.tcp.msl=1000
net.inet.tcp.msl: 15000 -> 1000

and now it works with no timeouts. I'm not sure if there is anything actionable to do.

[targos]

Closing as there was no recent activity