-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.pythonPRs and issues that require attention from people who are familiar with Python.PRs and issues that require attention from people who are familiar with Python.
Description
$ python3.7 ./configure.py ; NODE=$(which node) make test # generates -->
Failed to parse config file: Type names and field names cannot be a keyword: 'async'
That message is generated in inspector_protocol/code_generator.py because 'async' is a Python keyword in Python >= 3.7 and deps/v8/src/inspector/inspector_protocol_config.json contains async as a dict key.
UPDATE: This is now fixed in upstream https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 and now needs to be downstreamed.
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.pythonPRs and issues that require attention from people who are familiar with Python.PRs and issues that require attention from people who are familiar with Python.