Closed
Description
Some experimental warning messages' contents are not consistent, for example:
(node:70168) ExperimentalWarning: The ESM module loader is experimental.
(node:70372) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time
Shall we make them consistent? If so I'm willing to submit a PR to solve this.
There are two general methods to emit experimental warnings. I think we can make use of them.
JavaScript version
Lines 170 to 176 in 1549c8e
C++ version (introduced in #30617)
node/src/node_process_events.cc
Lines 102 to 112 in 1549c8e
Activity
[-]make all experimental warning messages consistent[/-][+]module: make all experimental warning messages consistent[/+]pd4d10 commentedon Dec 5, 2019
/cc @guybedford
guybedford commentedon Dec 5, 2019
We've had the
The ESM Loader is experimental
message for long enough that I think this one is fine to leave as-is until we remove it.If there are other inconsistencies though we should change them.
pd4d10 commentedon Dec 5, 2019
OK, get it. Found these flags. Seems not related to module.
[-]module: make all experimental warning messages consistent[/-][+]make all experimental warning messages consistent[/+]guybedford commentedon Dec 5, 2019
Those both seem worth doing to me. The added benefit is ensuring that the code examples follow the correct patterns for future reference.
guybedford commentedon Dec 5, 2019
(//cc @bmeck)