URL href mismatch from browsers

[addaleax]

• Version: master
• Platform: any
• Subsystem: url

What is the expected behavior?

> new (class extends URL { get hostname() { return 'twitter.com'; } })('http://google.com').href
'http://google.com/'

(I mean, I’m not 100 % sure, but this is what Firefox and Chromium return, and it’s what I would expect as well)

What do you see instead?

> new (class extends URL { get hostname() { return 'twitter.com'; } })('http://google.com').href
'http://twitter.com/'

@nodejs/url

[domenic]

Good find. Indeed, monkeypatching public APIs like hostname (whether via Object.defineProperty or via inheritance) should not impact the internal algorithms that back other public APIs like href.

[jasnell]

Yeah, I agree the behavior should align with browsers.