feat: implement array.pushArray to fix "Maximum call stack size exceeded" in array.push

[milahu]

Is your feature request related to a problem? Please describe.

in the wild, there exists this pattern to push elements from a source array to a destination array

destinationArray.push(...sourceArray) // ... = spread operator

this pattern is used cos its fast, faster than dst = dst.concat(src)
and cos its short, shorter than for (let i = 0; i < src.length; i++) dst.push(src[i])

but the source array is limited by the Maximum call stack size of around 100K in nodejs and 500K in firefox

// problem
[].push(...Array.from({ length: 1000*1000 }))
// Uncaught RangeError: Maximum call stack size exceeded

Describe the solution you'd like

destinationArray.pushArray(sourceArray)

// array.pushArray polyfill in typescript
(Array.prototype as any).pushArray = function pushArray(...otherList: any[]) {
  let c = 0; // count pushed elements
  for (let a = 0; a < otherList.length; a++) {
    const other = otherList[a];
    for (let i = 0; i < other.length; i++) {
      this.push(other[i]);
      c++;
    }
  }
  return c;
};

(someArray as any).pushArray(otherArray1, otherArray2, [otherItem])

Describe alternatives you've considered
using a library, but imho this should be a core feature

related

sample use case + code transformer sveltejs/svelte#6716
the code transformer could be implemented in eslint

[Ayase-252]

Thanks for feature request. Methods on Array is governed by the ECMAScript spec, though. Node.js doesn't implement them itself.

That's said, it should be proposed to TC39 to change the spec. See https://github.com/tc39/ecma262/blob/master/CONTRIBUTING.md.

[BridgeAR]

It's possible to work around that limitation:

let array = Array.from({ length: 1000*1000 })
array = [...array, ...array]

As @Ayase-252 already outlined, it's not up to Node.js to add new prototype functions to built-ins. As such I am going to close this as there's nothing on our side that we can do.

[milahu]

Ayase-252, thanks for the redirect

https://es.discourse.group/t/array-prototype-pusharray-to-fix-maximum-call-stack-size-exceeded-in-array-prototype-push/977

→ duplicate of https://es.discourse.group/t/array-method-to-append-another-array-in-place/98

BridgeAR, reassign is can be slower than for-push and requires destinationArray to be variable

edit: on simple data, concat is faster (never trust old benchmarks ...)

edit: never trust any benchmarks ^^ performance depends on the input data