net.isIP detection issue #40173
Labels
net
Issues and PRs related to the net subsystem.
Comments
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this issue
Sep 21, 2021
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a `0` as they're also considered valid octets. Fixes: nodejs#40173
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this issue
Sep 21, 2021
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a `0` as they're also considered valid octets. Fixes: nodejs#40173
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this issue
Sep 21, 2021
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a `0` as they're also considered valid octets. Fixes: nodejs#40173
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this issue
Sep 21, 2021
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a `0` as they're also considered valid octets. Fixes: nodejs#40173
|
Refs: #40174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v14.17.6
Platform
Linux 5.11.0-1017-aws #18~20.04.1-Ubuntu SMP Fri Aug 27 11:21:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
everywhere on linux '116.68.99.03' is a valid IP address and notation
How often does it reproduce? Is there a required condition?
tested on ubuntu8,10,14 on linux and mac.
What is the expected behavior?
should return 4
What do you see instead?
i see 0, which says it is an invalid IP address
Additional information
No response
The text was updated successfully, but these errors were encountered: