[REG 16.6->16.7] TCP/TLS drops AsyncLocalStorage

[orgads]

Version

v16.13.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

tcp/tls/async_hooks

What steps will reproduce the bug?

const { AsyncLocalStorage } = require('async_hooks');
const net = require('net');

const asyncLocalStorage = new AsyncLocalStorage();

asyncLocalStorage.run({val: 'abcd'}, () => {
  const socket = new net.Socket();
  socket.on('data', () => {
    // This is 'abcd' with Node 16.6.x, and undefined with Node >=16.7.0
    console.log(asyncLocalStorage.getStore()?.val);
  });
  socket.connect(80, 'google.com', function() {
    socket.write('GET /\n');
  });
});

TLS socket is also broken:

const { AsyncLocalStorage } = require('async_hooks');
const tls = require('tls');

const asyncLocalStorage = new AsyncLocalStorage();

asyncLocalStorage.run({val: 'abcd'}, () => {
  const socket = tls.connect({ host: 'google.com', port: 443 });
  socket.on('data', () => {
    // This is 'abcd' with Node 16.6.x, and undefined with Node >=16.7.0
    console.log(asyncLocalStorage.getStore()?.val);
    socket.end();
  });
  socket.on('error', console.error);
  socket.write('GET /\n');
});

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

It should write abcd.

What do you see instead?

undefined

Additional information

No response

[orgads]

Bisected with official versions. It broke between 16.6.2 and 16.7.0.

[orgads]

Bisected with git. Caused by #38468.

a80c989306c152e76fc03b59634303a11183e0c5 is the first bad commit
commit a80c989306c152e76fc03b59634303a11183e0c5
Author: Darshan Sen <[email protected]>
Date:   Thu Apr 29 20:47:09 2021 +0530

    async_hooks: merge resource_symbol with owner_symbol

    Signed-off-by: Darshan Sen <[email protected]>

    PR-URL: https://github.com/nodejs/node/pull/38468
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>

[targos]

@nodejs/async_hooks

[orgads]

ping? @RaisinTen?

[RaisinTen]

PR: #40741