Automated ICU update workflow failed

[targos]

https://github.com/nodejs/node/actions/runs/5300865700/jobs/9594690597

[richardlau]

node/tools/dep_updaters/update-icu.sh

Lines 62 to 64 in 8e710c9

	sed -i '' -e "s|\"url\": \"\(.*\)\".*|\"url\": \"$NEW_VERSION_TGZ_URL\",|" "$TOOLS_DIR/icu/current_ver.dep"
	sed -i '' -e "s|\"md5\": \"\(.*\)\".*|\"md5\": \"$CHECKSUM\"|" "$TOOLS_DIR/icu/current_ver.dep"

I'm guessing this was written on macOS as it's using sed -i '' which won't work in GNU sed -- see https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux/5694430#5694430

[marco-ippolito]

node/tools/dep_updaters/update-icu.sh

Lines 62 to 64 in 8e710c9

	sed -i '' -e "s|\"url\": \"\(.*\)\".*|\"url\": \"$NEW_VERSION_TGZ_URL\",|" "$TOOLS_DIR/icu/current_ver.dep"
	sed -i '' -e "s|\"md5\": \"\(.*\)\".*|\"md5\": \"$CHECKSUM\"|" "$TOOLS_DIR/icu/current_ver.dep"

I'm guessing this was written on macOS as it's using sed -i '' which won't work in GNU sed -- see https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux/5694430#5694430

Correct 🙂