streams: readable.setEncoding vs writable.setDefaultEncoding

[thurt]

Is there a reason why these two do not match each other in method name, and shouldn't they both return this?

[evanlucas]

The writable stream uses setDefaultEncoding because one can pass the encoding on each write() call. If encoding is not passed to write, then the default encoding is used. The readable stream uses whatever the current encoding is on every chunk that comes in.

Feel free to open a PR for Writable#setDefaultEncoding returning this.

Thanks!

[cjihrig]

This would have probably made for a good good first contribution label.

[evanlucas]

ah, good point. My bad