Skip to content

Support packaging debug binaries in vcbuild.bat #52281

@segevfiner

Description

@segevfiner

What is the problem this feature will solve?

When using Node as a shared library (Embedding) in Windows, you will also need a debug build of Node.js for building your application in debug mode as in Windows a debug build uses a debug version of the CRT which cannot be mixed with the release CRT (Has its own separate heap for example, even with CRT versions that are based on the universal CRT which also has separate debug/release builds).

The current vcbuild.bat doesn't support packaging a debug build though, which is useful to have a clean tree with the Node.js headers, shared library, node.def, and so on. So you don't have to write definitions to link against the Node.js source tree, which requires adding all the necessary include paths under deps for the dependencies.

What is the feature you are proposing to solve the problem?

Support building a package from vcbuild.bat for a debug build. Alternatively, we can also just include a Debug directory under the normal release package with the node shared library, import library and def file for debug if debug is built in that tree to produce one package that includes both release and debug builds for the shared node case.

What alternatives have you considered?

Wrangle the files by myself, which is annoying, and can introduce confusion over the directory layout of them as whatever way I choose is not a standard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.feature requestIssues that request new features to be added to Node.js.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions