Test runner: spec reporter abridges diff on `deepEqual` / `deepStrictEqual` assertion failure

[danburzo]

Version

v21.7.3

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

A failing deepEqual or deepStrictEqual assertion in a test, when using the spec test reporter.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

The full diff, or at least a larger print depth, of the actual/expected objects helps debug the failing tests.

What do you see instead?

$> node --test 'test/**/*.test.js'

  AssertionError [ERR_ASSERTION]: parse: /* A comment */ a
      at <project-path>//test/testcases.test.js:34:14
      at Array.forEach (<anonymous>)
      at test.objectPrintDepth (<project-path>/test/testcases.test.js:20:45)
      at async Test.run (node:internal/test_runner/test:640:9)
      at async startSubtest (node:internal/test_runner/harness:218:3) {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: { type: 'SelectorList', selectors: [ [Object] ] },
    expected: { type: 'SelectorList', selectors: [ [Object] ] },
    operator: 'deepStrictEqual'
  }

Additional information

Related to: #47051

[danburzo]

I narrowed it down to using the message argument in assert.deepEqual(). My tests were migrated from tape and all had the custom message. I was not aware the spec reporter prints the diff as the default message, and a custom message suppresses it.

[cjihrig]

@puskin94 by any chance do you know if this issue is still present, or if it was fixed by your work in #54759?

[puskin]

@cjihrig should definitely have been fixed by #54759 .
Just tested on main and working fine!

[cjihrig]

Thanks for checking! I'll go ahead and close this then.