Skip to content

v20.19.0 release notes - outdated messaging #57517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexsch01 opened this issue Mar 17, 2025 · 4 comments · Fixed by #57529
Closed

v20.19.0 release notes - outdated messaging #57517

alexsch01 opened this issue Mar 17, 2025 · 4 comments · Fixed by #57529

Comments

@alexsch01
Copy link
Contributor

alexsch01 commented Mar 17, 2025

Regarding this sentence in https://github.com/nodejs/node/releases/tag/v20.19.0

When the Node.js instance encounters a native ES module in require() somewhere outside node_modules for the first
time, it will emit an experimental warning unless require() comes from a path that contains node_modules.

This is not true in v20.19.0 due to

[[de313b2336](https://github.com/nodejs/node/commit/de313b2336)] - (SEMVER-MINOR) module: only emit
require(esm) warning under --trace-require-module (Joyee Cheung) https://github.com/nodejs/node/pull/56194

Test.mjs

export default class Test {}

main.cjs

console.log(process.version, require('./Test.mjs'))

$ node main.cjs
v20.19.0 [Module: null prototype] { __esModule: true, default: [class Test] }

Am I missing the point of the original sentence?

@aduh95
Copy link
Contributor

aduh95 commented Mar 17, 2025

/cc @marco-ippolito @joyeecheung

@marco-ippolito
Copy link
Member

Probably a mistake but I'll leave Joyee to re-word and then I'll update the release notes

@joyeecheung
Copy link
Member

Ah, yes, I wasn't thinking straight and got stuck with an older status when I proposed the changes to the release notes, sorry. The latest status should just be:

This feature has been tested on v23.x and v22.x, and we are looking for user feedback from v20.x to make more final tweaks before fully stabilizing it. It now no longer emits a warning unless --trace-require-module is explicitly used. If there happens to be any regressions caused by this feature, users can report it to the Node.js issue tracker. Meanwhile this feature can also be disabled using --no-experimental-require-module as a workaround.

Should I just update the changelog_v20.md and sync the rest (what are the rest, apart from the GitHub release notes and the blog?)

@marco-ippolito
Copy link
Member

marco-ippolito commented Mar 17, 2025

correct, thats it

aduh95 pushed a commit that referenced this issue Mar 22, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.

PR-URL: #57529
Fixes: #57517
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 1, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.

PR-URL: #57529
Fixes: #57517
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 1, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.

PR-URL: #57529
Fixes: #57517
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this issue May 1, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.

PR-URL: #57529
Fixes: #57517
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this issue May 2, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.

PR-URL: #57529
Fixes: #57517
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants