flaky: test_http2_debug #58353
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
s390
Issues and PRs related to the s390 architecture.
Comments
mhdawson
added
the
flaky-test
github-actions
bot
added
the
s390
|
Tried testing on windows? |
|
This has failed 20 PRs (!!) out of last 100 runs https://github.com/nodejs/reliability/blob/main/reports/2025-05-19.md |
|
It seems this started from #58124 |
Possibly related to #58124 (comment) / libuv/libuv#4768? |
|
This appears to be linuxone only cc @nodejs/platform-s390 |
The test in question isn't actively calling |
nodejs-github-bot
pushed a commit
that referenced
this issue
May 20, 2025
Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations. PR-URL: #58391 Refs: #58353 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Difference between the two logs: Failed output from the CISuccessful local outputThe test is complaining that it's not able to find the logs indicating a complete data frame is received on the client side. It seems in the CI on s390x somehow the server is going away too quickly and the client is not getting the complete data frame. Which very much looks like a test robustness issue. I am not sure if anyone from @nodejs/http2 (@jasnell or @trivikr ?) wants to fix it. If nobody responds I am inclined to just mark it as flaky for now. On a side note test-http2-ping.js looks like yet another test that's squeezing too many test cases into one file. Trying to check the debug log out of a test like this doesn't seem to be a good idea. But I don't feel too comfortable trying to split it due to the complexity and lack of comments in that test to understand what is safe to split. |
|
I've opened #58494 to mark this test as flaky on LinuxONE for now. |
jasnell
pushed a commit
that referenced
this issue
May 28, 2025
PR-URL: #58494 Refs: #58353 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]>
The libuv update landed on v22.x-staging yesterday (#57316) and the test failed in today's v22.x-staging daily build: https://ci.nodejs.org/job/node-daily-v22.x-staging/219/ |
richardlau
added a commit
that referenced
this issue
May 29, 2025
PR-URL: #58494 Refs: #58353 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]>
targos
pushed a commit
that referenced
this issue
May 31, 2025
Use spawnSyncAndAssert() so that the stderr is logged when it doesn't match expectations. PR-URL: #58391 Refs: #58353 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this issue
May 31, 2025
PR-URL: #58494 Refs: #58353 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test
test-http2-debug
Platform
Linux s390x
Console output
Build links
Additional information
No response
The text was updated successfully, but these errors were encountered: