-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
V8 version for 7.0.0 release #7904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @natorion |
Considering that the LTS release is going to live for some time I would try to maximize the time of "official support". This means go with 5.4. Waiting for V8 5.4 has a few other benefits too:
|
v7.0.0 is not going to be an LTS release. It will live for about 8 months. |
It would be nice to see V8 5.4 in the node v7.0.0 🐋 |
¯_(ツ)_/¯ as @targos says it'll only be around just over a half a year. |
V6 LTS doesn't need to release until mid-way through october somewhere though. |
I lean towards delaying V7 to wait for 54, while at the same time not having that determine when v6 becomes LTS. The net would either be no new stable for a few weeks which seems acceptable. |
What are the benefits of 54 compared to 53? |
@ronkorving it's all about performance and stability improvements with ES7 features support. |
We will likely be cutting the v7 branch off master in early september so we can begin making sure things are stable for the release. If we can land a pre-stable version of 54 there it would allow us to do additional testing to make sure things are going to work. It would be a bit odd, however, since we don't typically land v8's until they reach stable. I just don't like the idea of doing a series of v7 betas or release candidates with an older v8, then update v8 to 54 at the last minute before the actual v7.0.0 release. |
I think we can safely start the v7 betas with V8 5.4, that will likely enter the beta phase before September. |
I am not comfortable going stable with a beta V8. This is not necessarily about instability, but that V8 could remove features from beta when it goes into stable. (We had this once before, I forget the API) |
@targos ... when is 5.4 expected to go stable? Are there ABI changes expected between 5.3 and 5.4? |
I agree with @Fishrock123 on this, if 5.4 is not stable by the time we cut 7.0.0, we should not include it. If 5.4 does not break ABI compatibility then we ought to be able to include it in a future 7.x but I don't want to rush it just so we can get it in. |
IMO, the expectation that the next version is stable immediately when the previous goes LTS is a bit odd to me. If you want stability, you're probably going to be sticking to LTS versions, so the thing we call "stable" probably doesn't matter to you. In which case, I think it's fine to do beta/rc node versions with beta/rc V8 versions and the official release can be delayed as much as is needed for V8 to go stable. |
Estimated stable dates for Chromium (and hence V8) are listed here: https://www.chromium.org/developers/calendar. I think we should try to ship |
@Qard We did change the naming of v6 from Stable to Current as well, so I am assuming that v7 will also be named as "Current" vs "Stable" |
Correct. |
|
async/await has shipped, so it would be really good to wait (random bystander). https://codereview.chromium.org/2367203002 EDIT: oops, just realised that isn't in 5.4 anyway. Oh well, no async/await in Node 7 without --harmony. |
@wryun I could wait. It's async/await we're talking about. It would probably land in the LTS version as well, with a little patience, so everyone can rejoice. |
async/await will not land in |
I'll close this issue. |
I've just got an update to Chrome 54 so maybe V8 5.4 is stable now? OTH omahaproxy still points to v53 as stable so maybe I'm getting an A/B testing treatment. |
Now it's pointing to v54 |
So, what are we waiting for? ) |
nothing, it has landed in v7 😊 On Tue, Oct 18, 2016, 4:53 PM Alexander Abashkin [email protected]
|
Ok, when v7 will be available for downloading? 😄 |
@monolithed 25th of October, 2016 |
@monolithed You could try betas: https://nodejs.org/download/test/ |
I'm opening this to discuss about the V8 version that we would like to integrate in the v7.0.0 release and how it will affect the timing of the given release.
The LTS plan states that the current v6 release will transition to LTS when v7 is cut and this should happen in October.
According to this web page, next Chromium releases are estimated as:
It means that if we want to include V8 5.4 in the v7 version, we will have to wait until the second half of October. I think we should do that if possible and maybe start working very early on the integration of this version by skipping 5.3.
IMO this doesn't have to block the release of v6 LTS on October 1. We could have an overlap of current and LTS for a couple weeks.
Ref: #7824 (comment)
cc @ofrobots @srl295 @nodejs/lts @nodejs/v8
The text was updated successfully, but these errors were encountered: