Skip to content

test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let #10074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions test/parallel/test-https-truncate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var https = require('https');
const https = require('https');

var fs = require('fs');
const fs = require('fs');

var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
const key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
const cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');

// number of bytes discovered empirically to trigger the bug
var data = Buffer.allocUnsafe(1024 * 32 + 1);
const data = Buffer.allocUnsafe(1024 * 32 + 1);

httpsTest();

function httpsTest() {
var sopt = { key: key, cert: cert };
const sopt = { key: key, cert: cert };

var server = https.createServer(sopt, function(req, res) {
const server = https.createServer(sopt, function(req, res) {
res.setHeader('content-length', data.length);
res.end(data);
server.close();
});

server.listen(0, function() {
var opts = { port: this.address().port, rejectUnauthorized: false };
const opts = { port: this.address().port, rejectUnauthorized: false };
https.get(opts).on('response', function(res) {
test(res);
});
Expand All @@ -38,14 +38,14 @@ function httpsTest() {

function test(res) {
res.on('end', function() {
assert.equal(res._readableState.length, 0);
assert.equal(bytes, data.length);
assert.strictEqual(res._readableState.length, 0);
assert.strictEqual(bytes, data.length);
console.log('ok');
});

// Pause and then resume on each chunk, to ensure that there will be
// a lone byte hanging out at the very end.
var bytes = 0;
let bytes = 0;
res.on('data', function(chunk) {
bytes += chunk.length;
this.pause();
Expand Down