Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 4
#define V8_MINOR_VERSION 5
#define V8_BUILD_NUMBER 103
#define V8_PATCH_LEVEL 43
#define V8_PATCH_LEVEL 44

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/mirror-debugger.js
Original file line number Diff line number Diff line change
Expand Up @@ -1515,7 +1515,7 @@ PropertyMirror.prototype.name = function() {


PropertyMirror.prototype.toText = function() {
if (IS_SYMBOL(this.name_)) return %SymbolDescriptiveString(this.name_);
if (IS_SYMBOL(this.name_)) return %SymbolDescription(this.name_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the argument be couched in a %_ValueOf(...)? I see other calls to %SymbolDescription() do that but I presume that's for the case when IS_SYMBOL(x) === false && IS_SYMBOL_WRAPPER(x) === true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. %_ValueOf is only needed for object wrappers around primitives. Being a property key, it cannot be a wrapper here.

return this.name_;
};

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/debug-backtrace-text.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function listener(event, exec_state, event_data, data) {
// 2: [anonymous]
assertEquals("new Point(x=0, y=0)",
exec_state.frame(0).invocationText());
assertEquals("#<Object>[Symbol(Das Symbol)](x=0, y=0)",
assertEquals("#<Object>[Das Symbol](x=0, y=0)",
exec_state.frame(1).invocationText());
assertEquals("[anonymous]()", exec_state.frame(2).invocationText());
listenerCalled = true;
Expand Down