Skip to content

test: move resource intensive test to sequential #10744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: move resource intensive test to sequential #10744

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 11, 2017

test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

Fixes: #10742

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

@Trott
test: move resource intensive test to sequential
4abe302 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

Fixes: nodejs#10742
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 11, 2017
@Trott
Copy link
Member Author

Trott commented Jan 11, 2017

Sample failure of existing test in CI:

https://ci.nodejs.org/job/node-test-commit-osx/7145/nodes=osx1010/console

not ok 405 parallel/test-fs-readfile-tostring-fail
  ---
  duration_ms: 60.203
  severity: fail
  stack: |-
    timeout

@Trott
Copy link
Member Author

Trott commented Jan 11, 2017

CI stress test 32 simultaneous runs of existing parallel test failing:
https://ci.nodejs.org/job/node-stress-single-test/1101/nodes=osx1010/console

CI stress test same thing but in sequential succeeding:
https://ci.nodejs.org/job/node-stress-single-test/1102/nodes=osx1010/console

@Trott
Copy link
Member Author

Trott commented Jan 11, 2017

CI: https://ci.nodejs.org/job/node-test-commit/7176/

@Trott
Copy link
Member Author

Trott commented Jan 11, 2017

/cc @nodejs/testing @mscdex

@mscdex
Copy link
Contributor

mscdex commented Jan 11, 2017

LGTM

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. and removed dont-land-on-v7.x labels Jan 11, 2017
@santigimeno
Copy link
Member

LGTM

mhdawson
mhdawson approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 12, 2017

Anyone on board with a "this is trivial and doesn't need to wait 48 hours" for this?

Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2017
@Trott
test: move resource intensive test to sequential
d3eca02 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jan 12, 2017

Landed in d3eca02.

@Trott Trott closed this Jan 12, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@Trott
test: move resource intensive test to sequential
48c320a 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@Trott
test: move resource intensive test to sequential
2199033 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@Trott
test: move resource intensive test to sequential
ab1b709 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@Trott
test: move resource intensive test to sequential
30926ac 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: nodejs#10744
Fixes: nodejs#10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@Trott @MylesBorins
test: move resource intensive test to sequential
4e1642f 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
test: move resource intensive test to sequential
5d0cc61 
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: #10744
Fixes: #10742
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the fileread-seq branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-fs-readfile-tostring-fail on macOS
9 participants
@Trott @mscdex @santigimeno @jasnell @cjihrig @mhdawson @gibfahn @MylesBorins @nodejs-github-bot