src: use .data() instead of .c_str()

[sam-github]

Since C++11 onwards, .data() is required to be null terminated, and can
be used always instead of .c_str().

I mildly prefer c_str(), but if Node only supports C++11, this will convert to .data().

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

src

cf. #11006 (comment)

[sam-github]

/to @bnoordhuis

[sam-github]

Though it appears to be segfaulting :-). One of the c_str() may have been required. I'll rebuild to see what's going on.

[addaleax]

I mildly prefer c_str(), but if Node only supports C++11, this will convert to .data().

I personally prefer .c_str() for the cases where null termination actually matters and .data() when it doesn’t…

Anyway, if we want to do this bulk replacement, is there a way we can enforce it through the linter?

[sam-github]

@bnoordhuis maybe we should go the other way, then, and always choose c_str()?

[bnoordhuis]

I'm fine with c_str().