Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/parallel/test-internal-socket-list-receive.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const key = 'test-key';

const list = new SocketListReceive(child, key);
list.child.emit('internalMessage', { key, cmd: 'NODE_SOCKET_NOTIFY_CLOSE' });
list.child.emit('internalMessage', { key, cmd: 'NODE_SOCKET_GET_COUNT' });
}

// Verify that a "NODE_SOCKET_ALL_CLOSED" message will be sent.
Expand Down
22 changes: 22 additions & 0 deletions test/parallel/test-internal-socket-list-send.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,25 @@ const key = 'test-key';
assert.strictEqual(child.listenerCount('disconnect'), 0);
}));
}

// Verify that an error will be received in callback when child is
// disconnected after sending a message and before getting the reply.
{
const count = 1;
const child = Object.assign(new EventEmitter(), {
connected: true,
send: function(msg) {
process.nextTick(() => {
this.emit('disconnect');
this.emit('internalMessage', { key, count, cmd: 'NODE_SOCKET_COUNT' });
});
}
});

const list = new SocketListSend(child, key);

list.getConnections(common.mustCall((err, msg) => {
assert.strictEqual(err.message, 'child closed before reply');
assert.strictEqual(child.listenerCount('internalMessage'), 0);
}));
}