Skip to content

Conversation

jbunton-atlassian
Copy link
Contributor

Update the list of root certificates in src/node_root_certs.h

Cherry-picked 5ac20f7 from master

Certificates added:

  • AC RAIZ FNMT-RCM
  • Amazon Root CA 1
  • Amazon Root CA 2
  • Amazon Root CA 3
  • Amazon Root CA 4
  • Certplus Root CA G1
  • Certplus Root CA G2
  • Hellenic Academic and Research Institutions ECC RootCA 2015
  • Hellenic Academic and Research Institutions RootCA 2015
  • ISRG Root X1
  • LuxTrust Global Root 2
  • OpenTrust Root CA G1
  • OpenTrust Root CA G2
  • OpenTrust Root CA G3

Certificates removed:

  • Buypass Class 2 CA 1
  • EBG Elektronik Sertifika Hizmet Sağlayıcısı
  • IGC/A
  • Juur-SK
  • RSA Security 2048 v3
  • Root CA Generalitat Valenciana
Checklist
Affected core subsystem(s)
  • crypto

Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:
- AC RAIZ FNMT-RCM
- Amazon Root CA 1
- Amazon Root CA 2
- Amazon Root CA 3
- Amazon Root CA 4
- Certplus Root CA G1
- Certplus Root CA G2
- Hellenic Academic and Research Institutions ECC RootCA 2015
- Hellenic Academic and Research Institutions RootCA 2015
- ISRG Root X1
- LuxTrust Global Root 2
- OpenTrust Root CA G1
- OpenTrust Root CA G2
- OpenTrust Root CA G3

Certificates removed:
- Buypass Class 2 CA 1
- EBG Elektronik Sertifika Hizmet Sağlayıcısı
- IGC/A
- Juur-SK
- RSA Security 2048 v3
- Root CA Generalitat Valenciana

PR-URL: nodejs#12402
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. v6.x labels May 29, 2017
@bnoordhuis
Copy link
Member

I think this is already scheduled for inclusion in v6.x, see #12402 (comment).

(Aside: the commit in master is 6331b63.)

@gibfahn
Copy link
Member

gibfahn commented May 29, 2017

I think this is already scheduled for inclusion in v6.x, see #12402 (comment).

Yep, should go into a future 6.x release. The next candidate is 6.11.1, which is scheduled to be released on July 4th. If you're keen for it to land let us know.

@gibfahn
Copy link
Member

gibfahn commented May 29, 2017

Also if it cherry-picks cleanly, it doesn't need a backport PR, see the docs.

Closing this.

@gibfahn gibfahn closed this May 29, 2017
@jbunton-atlassian
Copy link
Contributor Author

Waiting until the next release is not a problem for us. Thanks :)

@jbunton-atlassian jbunton-atlassian deleted the update-node-v6-ca-roots branch December 19, 2018 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants