Skip to content

doc, meta: add @nodejs/documentation to CC table #13952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc, meta: add @nodejs/documentation to CC table #13952

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, meta

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 27, 2017
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jun 27, 2017
@jasnell
Copy link
Member

jasnell commented Jun 29, 2017

This shouldn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Jun 29, 2017
@vsemozhetbyt @jasnell
doc: add @nodejs/documentation to CC table
04faf0c 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 29, 2017

Landed in 04faf0c

@jasnell jasnell closed this Jun 29, 2017
@vsemozhetbyt vsemozhetbyt deleted the onboarding-extras-doc branch June 29, 2017 02:32
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@vsemozhetbyt @addaleax
doc: add @nodejs/documentation to CC table
e705845 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 29, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@vsemozhetbyt @addaleax
doc: add @nodejs/documentation to CC table
48fb758 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@vsemozhetbyt @addaleax
doc: add @nodejs/documentation to CC table
8fe7722 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@vsemozhetbyt @MylesBorins
doc: add @nodejs/documentation to CC table
92c46ff 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@vsemozhetbyt @MylesBorins
doc: add @nodejs/documentation to CC table
92850c3 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@vsemozhetbyt @MylesBorins
doc: add @nodejs/documentation to CC table
7648cca 
PR-URL: #13952
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@hiroppy hiroppy hiroppy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsemozhetbyt @jasnell @benjamingr @lpinca @cjihrig @hiroppy @richardlau @MylesBorins @nodejs-github-bot