Skip to content

Conversation

gabrielschulhof
Copy link
Contributor

Adding my name to README.md

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 8, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Commit title might be better as doc: add gabrielschulhof to collaborators but either way.

@gabrielschulhof
Copy link
Contributor Author

@gabrielschulhof
Copy link
Contributor Author

@benjamingr
Copy link
Member

Welcome aboard!!!

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

gabrielschulhof pushed a commit that referenced this pull request Aug 8, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@benjamingr
Copy link
Member

If you feel like it - you live near @petkaantonov maybe meet up?

@gabrielschulhof
Copy link
Contributor Author

Thanks all!

Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations.

@gabrielschulhof
Copy link
Contributor Author

Landed in 24c4505

@gabrielschulhof gabrielschulhof deleted the add-to-readme branch August 8, 2017 16:38
@vsemozhetbyt vsemozhetbyt mentioned this pull request Aug 8, 2017
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 9, 2017
addaleax pushed a commit that referenced this pull request Aug 9, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 3, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14692
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants